Github user solosky commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r132864458
--- Diff: common/src/main/java/org/apache/rocketmq/common/UtilAll.java ---
@@ -184,15 +184,27 @@ public static String timeMillisToHumanString3(final
long t) {
cal.get(Calendar.SECOND));
}
+ /**
+ * Estimates the disk usage percentage by the specified path.
+ *
+ * @param path Path.
+ * @return Disk usage percentage by path.
+ */
public static double getDiskPartitionSpaceUsedPercent(final String
path) {
- if (null == path || path.isEmpty())
+ if (null == path || path.isEmpty()) {
--- End diff --
we should use StringUtils.isBlank(..) instead as a basic practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
