Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/159#discussion_r135689182
  
    --- Diff: 
store/src/test/java/org/apache/rocketmq/store/ConsumeQueueTest.java ---
    @@ -207,4 +226,34 @@ public void dispatch(DispatchRequest request) {
                 UtilAll.deleteFile(new File(storePath));
             }
         }
    +
    +    @Test
    +    public void test_checkCommitLogAndConsumeQueueConsistent() throws 
Exception {
    +        DefaultMessageStore master = gen();
    +
    +        try {
    +            master.getDispatcherList().addFirst(new CommitLogDispatcher() {
    +
    +                @Override
    +                public void dispatch(DispatchRequest request) {
    +                    runCount++;
    +                }
    +
    +                private int runCount = 0;
    +            });
    +
    +            putMsg(master);
    +            // wait build consume queue
    +            Thread.sleep(2000);
    +
    +            ConsumeQueue cq = 
master.getConsumeQueueTable().get(topic).get(queueId);
    +            cq.checkCommitLogAndConsumeQueueConsistent();
    --- End diff --
    
    It seems that this test only covers the consistent condition? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to