vongosling commented on issue #169: [ROCKETMQ-292]Delete system.exit in MQAdminStartup URL: https://github.com/apache/incubator-rocketmq/pull/169#issuecomment-332111360 Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module. Have you provide the test module ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
