Dave wrote:
In the past our release criteria was "get three Incubator PMC members
to vote +1"
What is the standard now? Here are some questions to consider.
good question.
Generally speaking, those adding new features to Roller have the
responsibility to test and fix the features they're adding before we
make a release.
Once we've reached consensus that such testing is done, a release
should be made and we start creating release candidates do we simply
require three +1 votes from Roller committers to make the final
release?
One thing that I think would be a major help here would be just a little
bit more organization and documentation when it comes to releases. In
particular, having some form of test plan for each release would a good
idea so that when people get an RC they can see what to check.
Each new feature should list a few ways to test out that feature and
verify that it's working as expected. I am not advocating for something
super formal here, just a simple list like ...
New Feature: Templates by action
- when using a custom theme, go to the templates page and create a new
template for the 'permalink' action. enter in some test text, like
'blah blah', then save. then on your weblog, access a permalink url and
see that you permalink template is displayed.
This way if we have 1) a list of all new features/bug fixes which need
testing and 2) a simple test case to verify it then we can get people
more easily involved. Then for each test maybe we can have a checklist
of people who have tested it and claim it works so that we can try and
ensure that at least a couple people test each new feature, one of them
typically being the developer.
Are you allowed to vote +1 if you have not downloaded, installed and
at least done a quick sanity test (e.g. posting entries, trying a new
feature or two) on the release files? I'm pretty sure the answer is
no.
I agree, voting should be reserved for people who actually tested, not
just anyone who is a committer and is say "okay" to the release.
When a new RC is released does that invalidate existing votes on the
release? Not sure about this one. I guess it depends on the extent of
the changes. When I'm doing a release I want at least one person other
than me to sanity test the build.
tough call, but i would say no. if an RC has 5 bug fixes and 2 new
features and all but one of them is tested, but that last one requires a
code fix and updated RC then that shouldn't invalidate all previous
votes. However, each time a new RC is created there should at least be
a few people to d/l that specific RC and run through a basic deployment.
-- Allen
How do other Apache projects handle this?
- Dave
On 4/3/07, Anil Gangolli <[EMAIL PROTECTED]> wrote:
I downloaded the packages and verified all of the sigs.
I installed from the tar.gz binary (only) from scratch without problem.
I'm +1 on release if you're comfortable that the XSS issues prompting the
new RC were resolved by the fixes.
--a.
----- Original Message -----
From: "Dave" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Monday, April 02, 2007 8:16 PM
Subject: Re: VOTE: Release Apache Roller 3.1 RC7 fix release
> Has anybody taken a look at RC7 yet? If not, please do! We need to
> get this release out. Please download it and at least do some quick
> sanity tests like posting and entry and making a comment.
>
> - Dave
>
>
>
> On 3/23/07, Dave <[EMAIL PROTECTED]> wrote:
>> I incorporated the XSS fixes below into Roller 3.1, so now we have RC7
>>
>> - WEB-INF/lib/roller-web.jar
>> Now strips HTML from all incoming comment fields
>>
>> - WEB-INF/velocity/weblog.vm
>> Now HTML-escapes all comment-form fields before display
>>
>> - WEB-INF/jsps/authoring/CommentManagement.jsp
>> Now HTML-escapes all comment-form fields before display
>>
>> - WEB-INF/jsps/tiles/head.jsp
>> Eliminated the "look" request parameter, which was for debugging only
>>
>> - roller-ui/widgets/date.jsp
>> Now HTML-escapes value field of date widget
>>
>>
>> RC change list is here:
>> http://cwiki.apache.org/confluence/display/ROLLER/Testing+Roller+3.1
>>
>> Release files are here:
>> http://people.apache.org/~snoopdave/apache-roller-3.1/
>>
>> Please download, do some sanity testing and vote.
>>
>> - Dave
>>
>
