I've reviewed this patch and tested it out and everything looks good to me, so I am +1 to committing this work.

I am in favor of adding a screen name attribute to the User profile so that we can have a field separate from user name which users can use to indicate their public name any way they choose. This way username can remain a fixed field and more importantly it gets protected from public visibility which is a security concern in certain environments.

If anyone else has an alternate opinion please speak up, if I don't hear anything I plan to commit this next week.

-- Allen


Matthew Montgomery wrote:
Allen Gilliland wrote:
can you attach the patch to the Jira issue?

Done.


-- Allen


Matthew Montgomery wrote:
I took a stab at adding support for a screen name parameter which is one way to address ROL-1136.

http://opensource.atlassian.com/projects/roller/browse/ROL-1136

I have a patch that can be applied to the current trunk which touches some 25 files. It essentially adds a "screenName" parameter to the user profile and matches access occurrences with "fullName." I have also modified the included themes so that "screenName" is made visible in place of "username" and "fullName." I didn't attempt to add this change to source files located in the sandbox directory.

I made the following DB alteration.

alter table rolleruser add screenname varchar(255) not null;



Reply via email to