OK, then I'm +1 on these changes. Matt
On 5/29/07, Allen Gilliland <[EMAIL PROTECTED]> wrote:
Matt Raible wrote: > On 5/29/07, Allen Gilliland <[EMAIL PROTECTED]> wrote: >> Since 4.0 is a major release I'd like to suggest some cleanup and >> refactoring work which has no real bearing on functionality but I think >> provides some nice cleanup to the project and makes the code easier to >> understand and read. These don't have to be taken all together, so feel >> free to comment on them independently ... >> >> 1. Move Roller Weblogger code to new project space in apps/weblogger/* >> structured the same way as the Roller Planet project. This provides >> better consistency in the build environment. >> >> 2. Update Roller Weblogger java packaging from apache.roller.* to >> apache.roller.weblogger.*. It always kind of sucks to do major package >> renames like this, but I think this is a good thing and this should be >> the last time we have to do this for quite a while. > > Is the major reason for doing this because you expect to have > apache.roller.planet (and possibly other applications)? Yes. We have already setup planet in exactly that manner and while we haven't done any official releases of Roller Planet as it's own standalone application we really just need to develop that code base a bit more and polish it off and it could be released. -- Allen > > Matt > >> >> 3. Drop "Data" from the end of our pojo names. I still think that this >> convention is a waste and just muddies up our pojo names. At one point >> I think this convention was meant to identify which pojos were >> persistent, but I see no point in doing that because ultimately >> persistence is supposed to be transparent. Also, pretty much all our >> pojos are persistent anyways so all we've really done is made our pojo >> names longer for no reason. >> >> 4. Rename some pojos for consistency. One general theme here is to >> append "Weblog" in front of those objects which are directly attached to >> a weblog to make that relationship clear ... >> >> WebsiteData -> Weblog >> PermissionsData -> WeblogPermission >> FolderData -> WeblogBookmarkFolder >> BookmarkData -> WeblogBookmark >> HitCountData -> WeblogHitCount >> RefererData -> WeblogReferrer >> CommentData -> WeblogEntryComment >> EntryAttributeData -> WeblogEntryAttribute >> RoleData -> UserRole >> >> >> I think that's enough for now. Please weigh in with your thoughts on >> these, I'd like to start applying them soonish if we are agreed. >> >> -- Allen >> > >
-- http://raibledesigns.com
