Dave wrote:
On 7/10/07, Allen Gilliland <[EMAIL PROTECTED]> wrote
One thing that I didn't mention but is probably worth saying ... it's
also possible to design things a bit differently such that instead of
saving comments unmodified and then applying reformatting plugins as
they get displayed, we could apply the plugins on the incoming comment
and save the transformed version.
Each approach has it's own benefits. Applying plugins on the incoming
comment simplifies things quite a bit because we no longer need to add
the 'plugins' attribute to the db or pojo and it would improve
performance a fair amount since we wouldn't need to apply XX plugins per
comment during rendering. The downside is that since you modify the
comment before saving it you have no way of getting back to the original
comment if you wanted to, although that's not likely to be necessary.
I kind of like the idea of just applying the plugins once as the comment
is being submitted and then not having to worry about it after that, but
the solution I detailed above is slightly more flexible.
I don't have a strong feeling about this, but I guess I prefer to
store the raw comment data.
Actually, I remember why I abandoned this option as I was prototyping.
The major difficulty here is upgrade process because currently we are
doing transformations of comment content as it gets displayed and so if
we wanted to change that then it means going through all comments in the
db, applying the tranformations, and then re-saving. Basically, a major
PITA.
-- Allen
- Dave
