Hi,

While looking at org.apache.roller.weblogger.business.PermissionTest.testPermissionsLookups(),
I have a question.
The scenario is as follows:
   mgr.grantWeblogPermission(testWeblog, user, actions);
   ....
   perms = mgr.getWeblogPermissionsPending(TestUtils.getManagedUser(user));
   assertEquals(1, perms.size());

Does the above test fail?
It is because grantWeblogPermission should create a permission with pending = false
according to current implementation.

There are many ways to fix it. The following are some alternatives:
1. change to grantWeblogPermissionPending
2. or change to getWeblogPermissions
3. or change to assertEquals(0, perms.size())

Regards,
     Shing Wai Chan

Reply via email to