I agree, sounds good. Go for it.
-- Allen
srinivasa marreddy wrote:
Hi Sean,
You proposal sounds great and makes perfect sense . Looking
forward to see this feature in 4.1 M2.
--Srini
On 2/5/08, Sean Gilligan <[EMAIL PROTECTED]> wrote:
Hi Dave, et. al.
Do you know of any issues with using your patch when Roller is deployed
as the "root" webapp? (so http://photophys.com would not redirect to
http://photophys.com/photophys ?)
Allen Gilliland wrote:
All url building should be done using the URLStrategy, so if there are
a couple places which aren't doing that then they should be fixed.
Sounds right to me.
As Srinivasa said, putting the per weblog absolute url in the static
config doesn't make sense, it should be in the db and configurable at
runtime. In fact, it probably makes most sense for that to be a
property of a Weblog and hence in the weblog table.
Agreed.
It sounds like there are 2 problems which may not share the same
solution.
Solving for the subdomain situation should be just a matter of
choosing a different URLStrategy and RequestMapper which are designed
to expect urls of the form blog_handle.domain.com/rest/of/url. Your
proposal is more designed for solving the true multi-domain problem.
I think the two solutions should be developed together, and the
configuration should options should work as follows:
A) Roller deployment is configured by the server administrator with the
following settings:
1) Configurable URL strategy:
a) Current strategy
b) Subdomain strategy
2) A boolean setting that enables/disables blog admins from
setting custom domains
B) A Blog administrator can enable a custom domain on a per-blog basis
(if enabled by the server admin)
* Requires an additional setting on the Weblog Settings UI
screen (hidden when disabled)
* Custom domains on Weblogs might require the subdomain URL
strategy (?)
* Can Open
I'd be willing to make these changes for "4.1M2" if people think this
approach makes sense.
-- Sean
p.s. Welcome back Allen!
