Dave wrote:
On Thu, Jan 15, 2009 at 3:33 PM, Vivien Barousse
<[email protected]> wrote:
I'm currently working on Roller source code, and I just had a look into both
the JPARefererManagerImpl.applyRefererFilters() and
JPARefererManagerImpl.applyRefererFilters(Weblog website) methods.
In these methods, we can find the following lines :
String[] blacklist = StringUtils.split(
StringUtils.deleteWhitespace(website.getBlacklist()),",");
These lines are splitting the blacklist string on comas in order to separate
blacklist words, but this string actually contains words separated by line
breaks.
In this a bug in these methods, or am I missing something ?
You are not missing anything. That looks like a real live bug. We used
to use commas to separate blacklist entries, but we switched to
newlines in 3.x (I think).
- Dave
I filed a bug into JIRA to reference this issue (*ROL-1779 -
http://tinyurl.com/ROL-1779)*.
Also, I saw that regex expressions located in blacklist terms aren't
interpreted (because, I think, Roller 3.x didn't have regex blacklist
terms). This is also referenced in the issue.
I'd like to work on this to propose a patch asap.
