RC5 tests - encoding error in comments

[Susanne Gladén]

Hi,

I think I have found a bug in the code concerning weblogentry comments.

If I add a comment to a weblog entry:  "Fint väder idag"
Then the comment is displayed as: "Fint väder idag"


In WeblogEntryCommentWrapper.java in method getContent()

    public String getContent() {

        String content = this.pojo.getContent();

        // escape content if content-type is text/plain
        if("text/plain".equals(this.pojo.getContentType())) {
            content = StringEscapeUtils.escapeHtml(content);
        }

        // apply plugins
        PluginManager pmgr = WebloggerFactory.getWeblogger().getPluginManager();
        content = pmgr.applyCommentPlugins(this.pojo, content);

        // always add rel=nofollow for links
        content = Utilities.addNofollow(content);

        return content;
    }

First the content is transformed in:

        if("text/plain".equals(this.pojo.getContentType())) {
            content = StringEscapeUtils.escapeHtml(content);
        }

Then the content transformed once again in HTMLSubsetPlugin.java    (
content = pmgr.applyCommentPlugins(this.pojo, content);)


This makes the string escaped twice.


I found in Utilities.transformToHTMLSubset(String s)  that you try to
make a fix for this problem for some characters by calling s.replace(
... )
But its difficult to list all Latin1 characters  ...


/Susanne