Hi Dave, no problem with separating out planet, but adding planet-web
just adds 5 seconds to the build time (roughly 2% longer), at least on
my machine, and is good for others looking at the code and for letting
us know if/when a planet-web dependency has fallen out of date and is no
longer available, so I'd like to reactivate it for the time being:
[INFO] Roller Project - Trunk ............................ SUCCESS [0.359s]
[INFO] Roller Core - Trunk ............................... SUCCESS [2.450s]
[INFO] Roller Test Utilities - Trunk ..................... SUCCESS [0.835s]
[INFO] Roller Planet Business - Trunk .................... SUCCESS [24.532s]
[INFO] Apache Roller Planet Web Application .............. SUCCESS [4.629s]
[INFO] Roller Weblogger Business Module - Trunk .......... SUCCESS
[2:33.167s]
[INFO] Roller Weblogger Web Module - Trunk ............... SUCCESS
[1:02.223s]
[INFO] Roller Weblogger Web Application - Trunk .......... SUCCESS [45.618s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 4:54.162s
But I noticed we have a more fundamental problem--we're presently
maintaining two sources of record for the planet source code, something
I'd like to rectify ASAP if I can:
1.) http://svn.apache.org/viewvc/roller/planet/core/trunk/ (Ant-based
Planet)
and
2.) http://svn.apache.org/viewvc/roller/trunk/ (Maven-based Planet)
It seems that when #1 was done the source code wasn't deleted in #2;
OTOH, if #2 was based on #1 I think I can go ahead and delete #1 to
solve the multiple source problem; later, we'll just need to move
planet-web and planet-business (and a new pom.xml) to #1's location and
then we'll have two separate web apps. (We might keep planet-business
in its present location for a longer term due to it being a dependency
for Roller right now.)
So I'd like to:
1.) Reactivate planet-web in the pom.xml
2.) Delete the source code in #1 (svn delete) so we're at one source of
record.
3.) (at a later date) Move planet-web to 1's location, with a new
pom.xml and a dependency on planet-business (and possibly test-utils) in
Roller.
4.) (if I can sever the planet-business dependency from Roller), move
planet-business there too.
WDYT?
Glen
On 03/14/2013 09:42 AM, Dave wrote:
I don't think we need it, and since Planet-Web is a completely separate web
application from Roller, I think it makes sense for it to be should be
built separately.
- Dave
On Sun, Mar 10, 2013 at 5:53 PM, Glen Mazza <[email protected]> wrote:
Hi, per
https://issues.apache.org/**jira/browse/ROL-1865<https://issues.apache.org/jira/browse/ROL-1865>,
we're not adding planet-web to our parent pom.xml so it's not getting built
on a mvn clean install. Adding it, the module builds fine, but since we're
not releasing planet-web maybe we don't need to add it to our pom.xml. I
can go either way on this. Thoughts?
Glen
