Remove assembly-war submodule?

[Glen Mazza]

Hi Team, the assembly-war submodule doesn't appear needed anymore. We 
just have a single build that works with Tomcat, GlassFish and JBoss 
(the latter needing some user modification of the persistence.xml to 
declare one's database type, as described in the install guide), and the 
only file it filtered out, an internal Jetty one, was deleted from the 
project some days ago.  In other words the WAR that assembly-war creates 
is the same as the WAR created by the app module.

I've tested that the assembly-release plugin will happily work with the 
war that "app" generates, so anybody mind if I delete assembly-war?  Due 
to the naturally low volume of downloaders as well as the 
higher-than-average skills of people deploying on JEE app servers, I 
don't see us ever needing to create separate WARs depending on App 
server anymore, but even if we did I think instead developing submodules 
that create an EAR for the JEE server incorporating the lone WAR with 
modifications would be the better approach anyway (such as here: 
https://github.com/gmazza/blog-samples/blob/master/web_service_ear_tutorial/ear/pom.xml#L14-21)

[I'm not sure we even need the assembly-release submodule, it can 
probably be incorporated into app's pom (only 60 more lines), but app's 
pom still needs a bit more cleaning out & simplification so we can hold 
off on that right now.]

Regards,
Glen