Please do not remove outputtype either. Page templates can be used to generate XML, JSON and other types of output and you need to be able to set the content-type when you produce those types.
- Dave On Sat, Jul 19, 2014 at 8:54 AM, Dave <snoopd...@gmail.com> wrote: > isNavBar is used by the #showPageMenu() macro and to determine which page > templates to show in the page menu. Do not remove it or you will break lots > of themes, including mine. You can set the value in the advanced settings > part of the page template edit page. > > - Dave > > > > On Fri, Jul 18, 2014 at 6:51 PM, Glen Mazza <glen.ma...@gmail.com> wrote: > >> Hi team, I'm in the process of the WEBPAGE --> WEBLOG_CUSTOM_TEMPLATE >> work (https://issues.apache.org/jira/browse/ROL-2039) and confirming >> that the 5.0.4 -> 5.1 migration will work with the changes. (I did >> custom_theme_rendition earlier today and it seems to be in good shape.) >> Question: The webpage table has a boolean "navbar" column that appears >> always "false", even in 5.0.x, I don't know what it's for, >> ThemeTemplate.java says this: >> >> /** >> * Is the Template to be included in the navbar? >> */ >> boolean isNavbar(); >> >> Can we get rid of this column? There appear to be three other columns we >> can potentially remove from WEBPAGE/WEBLOG_CUSTOM_TEMPLATE: decorator, >> template, and templatelang (the latter two columns, which are now in >> custom_template_rendition, can be deleted after the 500-to-510 migration >> script successfully copies those values from webpage into >> custom_template_rendition.) ThemeManagerImpl says "decorators are >> deprecated starting in 4.0" so it looks safe to remove. >> >> One more column we can possibly remove from the webpage table is >> "outputtype" -- AFAICT it's always null in 5.0.4 & 5.1, anyone know if this >> is still useful? This is what WeblogTemplate and TemplateEdit.java have to >> say about it: >> >> /** >> * Content-type rendered by template or null for auto-detection by >> link extension. >> */ >> >> if (getBean().getAutoContentType() == null || >> !getBean().getAutoContentType()) { >> templateToSave.setOutputContentType(getBean().getManualContentType()); >> } else { >> // empty content-type indicates that template uses >> auto content-type detection >> templateToSave.setOutputContentType(null); >> } >> >> If this is something that, if it ever became useful in the future, it >> would be at the rendition level, not the higher-level template level, I can >> pull it out of WEBLOG_CUSTOM_TEMPLATE, and later, if there's ever a demand >> for it, place it in custom_template_rendition. >> >> Regards, >> Glen >> > >
