Hi Dave, I don't understand the use case of "navbar", and it doesn't
seem to work today anyway. I took one of my templates, "_header", and
marked it navbar-able. So my navbar menu indeed changed from:
Front Page
Weblog
Login
to
Front Page
Weblog
_header
Login
Even without logging in, "_header" is viewable to the world now.
Question: What is the use case for mass-broadcasting Velocity templates
to your blog readership? Why would anyone want that? If it's to
facilitate tweaking of templates, that can be done by keeping the
template in a separate browser tab while hitting refresh on the tab
displaying the blog. And we already have a "design: template page" menu
item getting them one click away from template modifications anyway.
Regardless, it doesn't work anyway, it hyperlinks to this URL:
https://web-gmazza.rhcloud.com/blog/page/ which just returns a 404. So
this would need to get fixed, but I don't see this an itch that anyone
will need to scratch. Further, it seems to have lost its semantic
meaning in 5.1, in the past _header would have pointed to a single
template, but now that multi-renditions are available, which one should
it point to?
Do you still want to retain this functionality in 5.1, even if it
presently doesn't work? Otherwise, what I can do is have
WeblogTemplate.isNavBar() hardcoded to always return false, so it won't
break anyone's templates, it just will never render, and remove isNavBar
from the data model and the UI screen.
Cheers,
Glen
On 07/19/2014 08:54 AM, Dave wrote:
isNavBar is used by the #showPageMenu() macro and to determine which page
templates to show in the page menu. Do not remove it or you will break lots
of themes, including mine. You can set the value in the advanced settings
part of the page template edit page.
- Dave
On Fri, Jul 18, 2014 at 6:51 PM, Glen Mazza <glen.ma...@gmail.com> wrote:
Hi team, I'm in the process of the WEBPAGE --> WEBLOG_CUSTOM_TEMPLATE work
(https://issues.apache.org/jira/browse/ROL-2039) and confirming that the
5.0.4 -> 5.1 migration will work with the changes. (I did
custom_theme_rendition earlier today and it seems to be in good shape.)
Question: The webpage table has a boolean "navbar" column that appears
always "false", even in 5.0.x, I don't know what it's for,
ThemeTemplate.java says this:
/**
* Is the Template to be included in the navbar?
*/
boolean isNavbar();
Can we get rid of this column? There appear to be three other columns we
can potentially remove from WEBPAGE/WEBLOG_CUSTOM_TEMPLATE: decorator,
template, and templatelang (the latter two columns, which are now in
custom_template_rendition, can be deleted after the 500-to-510 migration
script successfully copies those values from webpage into
custom_template_rendition.) ThemeManagerImpl says "decorators are
deprecated starting in 4.0" so it looks safe to remove.
One more column we can possibly remove from the webpage table is
"outputtype" -- AFAICT it's always null in 5.0.4 & 5.1, anyone know if this
is still useful? This is what WeblogTemplate and TemplateEdit.java have to
say about it:
/**
* Content-type rendered by template or null for auto-detection by
link extension.
*/
if (getBean().getAutoContentType() == null ||
!getBean().getAutoContentType()) {
templateToSave.setOutputContentType(getBean().getManualContentType());
} else {
// empty content-type indicates that template uses
auto content-type detection
templateToSave.setOutputContentType(null);
}
If this is something that, if it ever became useful in the future, it
would be at the rendition level, not the higher-level template level, I can
pull it out of WEBLOG_CUSTOM_TEMPLATE, and later, if there's ever a demand
for it, place it in custom_template_rendition.
Regards,
Glen
