On Thu, Aug 21, 2014 at 12:42 PM, Glen Mazza <glen.ma...@gmail.com> wrote:
> On 08/21/2014 05:39 AM, Greg Huber wrote: > >> Glen, >> >> On upgrading/testing. >> >> ## >> >> One of my databases failed on this statement on the upgrade. The index did >> not exist. >> >> ALTER TABLE bookmark_folder DROP INDEX folder_namefolderid_uq; >> >> Its does mention it may not exist. >> >> > Hi Greg, yes, I put a change in the code for dropping of nonexistent > indexes to be a non-fatal upgrade error, seeing that we don't need to fail > if we're trying to delete something that already doesn't exist. Some > roller installs have indexes that others don't, and I just want the upgrade > to proceed in those cases, rather than leave people with a half-completed > database. > > http://svn.apache.org/viewvc/roller/trunk/app/src/main/ > java/org/apache/roller/weblogger/business/startup/SQLScriptRunner.java?r1= > 1580425&r2=1613234&diff_format=h The problem with that fix is that many sys admins prefer (that was my first inclination and Greg's too) to run the database script "manually" instead of letting Roller run the script. When you run the script manually, that error causes the script to fail. Possible solutions: * In the upgrade docs, tell people not to run the script manually * In the upgrade docs, tell people that want to run manually they should use a "continue on error" appropriate for their database (on MySQL this is the --force option) * Provide a command line program that does runs the migration and ignores errors - Dave
