+1 The only thing is on ROL-2052 <https://issues.apache.org/jira/browse/ROL-2052> #2 switching back to a shared theme now overwrites your custom style sheet without any warnings, if you have not made a backup your changes will be lost. Automatically overwriting against having to manually delete it, the latter seems the safest way. Possibly add a warning message saying to delete your custom style sheet?
On 30 September 2014 01:48, Glen Mazza <glen.ma...@gmail.com> wrote: > I'll look into those issues for the current trunk but, absent any negative > votes for the next three hours, will go ahead and release Roller 5.1.1, > probably on Thursday. > > Thanks, > Glen > > On 09/29/2014 04:14 PM, Dave wrote: > >> I was able to download the release files, validate the signatures and run >> the tests successfully. I did notice that there is a script "copy.sh" in >> the root directory of the source release, that may have been committed >> accidentally. Also, the "mvn jetty:run" command did start Roller properly >> as it once did. I don't think either of those things should hold back the >> release. >> >> - Dave >> >> >> On Fri, Sep 26, 2014 at 6:04 PM, Glen Mazza <glen.ma...@gmail.com> wrote: >> >> OK, team, I'm happy to report that ROL-2051 has been fixed also for >>> custom >>> themes, so we're good to go to vote again. The link below to the >>> distributions are the same, except they now have RC2 in them. >>> >>> To test the blogs with mobile/tablet devices, try your own smartphone or >>> hit F12 from Google Chrome. Some sample blogs using RC2: >>> >>> http://web-gmazza.rhcloud.com/blog/ >>> http://web-gmazza.rhcloud.com/frontpage/ >>> http://web-gmazza.rhcloud.com/fauxcoly/ >>> http://web-gmazza.rhcloud.com/testdual/ >>> http://web-gmazza.rhcloud.com/gaurav/ >>> http://web-gmazza.rhcloud.com/basic/ >>> >>> Here's my +1. Vote will be held through the end of Monday Eastern USA >>> time. >>> >>> Regards, >>> Glen >>> >>> >>> On 09/26/2014 09:12 AM, Glen Mazza wrote: >>> >>> Hi team, I think I've figured out the problem in ROL-2051, if the theme >>>> is custom it will still have problems rendering on smart phones, shared >>>> themes work fine now but custom still needs fixing. So I'll have to -1 >>>> this, fix the problem and get an RC2 out. :( >>>> >>>> Please be careful/conservative with any commits you make in the interim >>>> as they will end up going into the upcoming Roller 5.1.1. >>>> >>>> Glen >>>> >>>> On 09/26/2014 09:04 AM, Glen Mazza wrote: >>>> >>>> Hi Team, this is a vote to release Roller 5.1.1. Binaries and source >>>>> are here: >>>>> >>>>> https://dist.apache.org/repos/dist/dev/roller/roller-5.1/v5.1.1/ >>>>> >>>>> This patch release fixes the following problems: >>>>> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-1387";>ROL- >>>>> 1387</a> >>>>> - In creating tag aggregate counts (for tag clouds, etc.), count tags >>>>> only >>>>> from published blog entries</li> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-1620";>ROL- >>>>> 1620</a> >>>>> - Plus signs in Category names result in 404s for Atom and RSS >>>>> feeds</li> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-2050? >>>>> focusedCommentId=14116588&page=com.atlassian.jira. >>>>> plugin.system.issuetabpanels:comment-tabpanel#comment- >>>>> 14116588">ROL-2050</a> >>>>> - Have Design Tab default to Templates page when custom themes are >>>>> being >>>>> used (speeds up template customization)</li> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-2051";>ROL- >>>>> 2051</a> >>>>> - Themes not falling back to standard templates when mobile ones >>>>> undefined >>>>> (affecting ability for Roller to be read from tablets and >>>>> smartphones.)</li> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-2052";>ROL- >>>>> 2052</a> >>>>> - Custom stylesheets not being updated correctly when user switches >>>>> between >>>>> shared and custom themes.</li> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-2054";>ROL- >>>>> 2054</a> >>>>> - Newly saved categories not appearing on blog</li> >>>>> <li><a href="https://issues.apache.org/jira/browse/ROL-2055";>ROL- >>>>> 2055</a> >>>>> - Comment search should be case-insensitive</li> >>>>> >>>>> For ROL-2051, I confirmed with my blog that all themes that ship with >>>>> Roller are working on smart phones, I tested using Google Chrome's >>>>> developer tools and my own smartphone. However, my particular >>>>> non-packaged >>>>> theme (Rolling from Roller extras) is working only off-and-on. It may >>>>> be >>>>> related to the theme's CSS rules, I haven't investigated. What we >>>>> have is >>>>> at least a radical improvement though over 5.1.0 when *none* of the >>>>> themes >>>>> (except the dual theme, basic-mobile) were working on non-standard >>>>> displays. >>>>> >>>>> Dave, as mentioned in the preceding email, don't forget to update >>>>> rollerweblogger with "alter table weblog add defaultplugins >>>>> varchar(255);" >>>>> to get you up to the official 5.1.0 database, 5.1.1 will not work >>>>> without >>>>> that addition. >>>>> >>>>> For the few upgrading from Roller 5.1.0 to 5.1.1, Roller is coded to >>>>> ask >>>>> if you want to update your database tables, still hit "yes", it won't >>>>> make >>>>> any changes because there are none coded, it will just upgrade your >>>>> Roller >>>>> db version in the roller_properties table to "511". >>>>> >>>>> Note I just copied over the documentation from the 5.1.0 to 5.1.1, as >>>>> it's undergone no changes. >>>>> >>>>> Here's my +1. Vote will be held for 72 hours. >>>>> >>>>> Regards, >>>>> Glen >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >
