Greg and Kohei: thanks so much for helping out and giving good feedback.
This is great!
I hope to work through most or all of these issues today.
I'm working in the roller-5.2.0 branch.
Dave
On Sun, Oct 8, 2017 at 4:14 AM Greg Huber <gregh3...@gmail.com> wrote:
> Dave,
>
> Looks ok, but found some new items.
>
> ######
>
> Needs some more allowed methods.
>
> eg createNewDirectory for the meda files create action. btw, rather than
> creating global-allowed-methods you can add them to the action itself in a
> <allowed-methods> :
>
> <action name="mediaFileView"
> class="org.apache.roller.weblogger.ui.struts2.editor.MediaFileView">
> <result name="success" type="tiles">.MediaFileView</result>
> <result name="success.json"
> type="dispatcher">/WEB-INF/jsps/editor/MediaFileViewLight.jsp</result>
>
> <allowed-methods>deleteFolder,..,createNewDirectory</allowed-methods>
> </action>
>
> Also these are needed:
>
> Method flushCache for action maintenance is not allowed!
> Method reset for action maintenance is not allowed!
> Method enable for action pings is not allowed!
> Method pingNow for action pings is not allowed!
>
> ######
>
> The roller.properties in the war has hard coded stuff
>
> mediafiles.storage.dir=/Users/dave/roller_data/mediafiles
> search.index.dir=/Users/dave/roller_data/search-index
>
> but checking the source its
>
> mediafiles.storage.dir=${user.home}/roller_data/mediafiles
> search.index.dir=${user.home}/roller_data/search-index
>
> so not sure on this.
>
> ###
>
> Checking the logs, other than the had coded roller.properties, no errors.
>
>
> Cheers Greg
>
>
> On 6 October 2017 at 13:07, Dave <snoopd...@gmail.com> wrote:
>
> > I'm going to extend the vote over the weekend.
> >
> > Please review and vote!
> >
> > Dave
> >
> >
> > On Sun, Oct 1, 2017 at 10:47 AM Dave <snoopd...@gmail.com> wrote:
> >
> > > I've prepared a third release candidate for Roller 5.2.0. This release
> is
> > > primarily a bug fix release, with lots of fixes from Kohei. I have
> > created
> > > a release candidate which you can find here:
> > >
> > > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.
> > 2.0-rc-3/
> > >
> > > And the list of issues resolved is here:
> > >
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12310906&version=12340980
> > >
> > > Thanks to Greg for finding some issues in rc-2. I believe I have fixed
> > all
> > > the problems that he found plus a couple more. Here's what has changed
> > > since rc-2:
> > >
> > > 1. roller.log location now default to the Catalina Base logs
> directory
> > > 2. Added cache "clear" to list of allowed Struts DMI methods
> > > 3. Use namespace not name in struts.xml Chained Actions
> > > 4. Use "var" instead of "id" for some s:iterator tags
> > > 5. Now shows Media File URL correctly in Media File View modal
> > >
> > > I'm currently running this code on rollerweblogger.org and it seems to
> > be
> > > working well.
> > >
> > > Please take a look and vote.
> > >
> > > Thanks,
> > > Dave
> > >
> >
>
