Vote cancelled. I'm going to try to get a couple more bug fixes in before 5.2.3.
Thanks, Dave On Thu, Jan 31, 2019 at 5:13 PM Dave <snoopd...@gmail.com> wrote: > Thanks Jason! I left a comment on the PR. > > Dave > > > On Wed, Jan 30, 2019 at 12:51 PM Jason Pyeron <jpye...@pdinc.us> wrote: > >> > -----Original Message----- >> > From: Greg Huber >> > Sent: Tuesday, January 29, 2019 3:24 AM >> > >> > Checking the logs, did not get any errors (or previous) on the upgrade. >> > >> > Testing with >> > 510-to-520-migration.sql >> > >> > I changed roller.database.version to 510 and restarted, roller changed >> it >> > to 523. >> > >> > INFO 2019-01-29 08:11:53,972 DatabaseInstaller:upgradeDatabase - >> Database >> > is old, beginning upgrade to version 523 >> > >> > Not sure how to check if it has actually run (mariadb) >> > alter table weblogentry modify updatetime datetime(3) not null; >> > Reduces the time stamps to milliseconds? >> > >> > if I dump the table: >> > CREATE TABLE IF NOT EXISTS `weblogentry` ( >> > `pubtime` datetime DEFAULT NULL, >> > `updatetime` datetime NOT NULL, >> > ) ENGINE=MyISAM DEFAULT CHARSET=latin1; >> > >> > +1 (b) >> > >> > Cheers Greg >> > >> > On Sun, 27 Jan 2019 at 17:01, Dave <snoopd...@gmail.com> wrote: >> > >> > > Hi Roller community, >> > > >> > > I propose that we release the current contents of the Roller 5.2.x >> > branch >> > > as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is >> > > broken. This is the fix: >> > > >> > > Database upgrading does not work >> > > https://issues.apache.org/jira/browse/ROL-2127 >> >> I found an issue with Oracle DB >> >> https://issues.apache.org/jira/browse/ROL-2129 >> >> I made a pull request. >> >> -Jason >> >>