Hi Greg,

I fixed a couple of these and have questions about the others. See inline
below:


On Mon, Apr 13, 2020 at 4:07 AM Greg Huber <gregh3...@gmail.com> wrote:

>
> ##
>
> http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser
> Missing value for createWebsite.timeZone
>

Fixed.


> ##
> Remember me seems to have gone?
>

Remember Me is working for me. You do now have to specify a rememberme.key
that is NOT "springRocks" because that is the old default, but I think that
was in 6.0.0 already. You want something unique and secret.



> ##
> http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol
> Editor Pages are these still valid?
> Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp
>

I'm not sure why you are seeing this. The default in runtimeConfigDefs.xml
is "editor-text.jsp,editor-summernote.jsp" which is correct. The RTE and
Xinha editors are gone. Are you using an existing database for your testing
of 6.0.1 rc1?



> ##
> Duplicate /n when editing a comment
> org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet
> String content = Utilities.escapeHTML(c.getContent());
> content = WordUtils.wrap(content, 72);
> content = StringEscapeUtils.escapeEcmaScript(content);
> It would be better to leave the wrapping to the ui.  ie remove
> WordUtils.wrap(content, 72);
>

Fixed.

Thanks for the review Greg.

Dave




> On 10/04/2020 21:42, Dave wrote:
> > I have prepared a release candidate for a Roller 6.0.1 release based on
> > latest code in the roller-6.0.x branch.  This release will be a minor bug
> > fix release. It fixes two bugs, which you can see here:
> >
> >     https://issues.apache.org/jira/projects/ROL/versions/12347761
> >
> > A release candidate files for this release are available here:
> >
> >     https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/
> >
> > Please vote +1 to release or -1 with reason(s) not to release.
> >
> > I plan to leave this vote open until April 19 to allow folks time to
> test.
> >
> > Thanks,
> > Dave
> >
>

Reply via email to