mbien commented on pull request #75: URL: https://github.com/apache/roller/pull/75#issuecomment-777361323
looks good, some remarks: - volatile could be removed again if the Set is made final (and cleared + reused in loadBannedIps()) - loadBannedIpsIfNeeded is only called with forceLoad set to false -> opportunity to be simplified. sidenote: I noticed that the IPBanList is indirectly polling the modification time of the file via isBanned(). Maybe it could be polled only once per second? I don't know the exact requirements for this feature however. Maybe @snoopdave could help. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
