snoopdave opened a new pull request, #169:
URL: https://github.com/apache/roller/pull/169
The bundled frontpage theme's blog-directory page filters its listing by a
`letter` request parameter and builds a back-link from a `weblog` parameter.
This change validates and normalizes both before use and escapes them at
output.
## What changed
- Accept a single ASCII letter, normalize lowercase to uppercase, and
require it
to be a key in the business layer's weblog-letter map.
- Fall back to the full directory ("All weblogs") for missing or invalid
input,
without redirecting, erroring, or echoing the rejected value.
- Escape the accepted value at HTML output even after validation.
- Resolve the `weblog` parameter to an existing weblog and build the
back-link
from the resolved handle, escaped at output.
## Tests
- Missing input renders "All weblogs"; uppercase and lowercase valid keys
select
the same group.
- Multi-character, numeric, punctuation, and non-ASCII values fall back to
the
full listing and do not appear in the response, raw or encoded.
- Paging retains only the normalized, validated key.
- Strengthened business-map test asserts the exact A–Z key set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
