mraible commented on code in PR #168:
URL: https://github.com/apache/roller/pull/168#discussion_r3891438824
##########
app/src/main/webapp/WEB-INF/jsps/editor/Bookmarks.jsp:
##########
@@ -338,7 +338,7 @@ We used to call them Bookmarks and Folders, now we call
them Blogroll links and
function confirmDeleteFolder() {
$('#boomarks_delete_folder_folderId').val($('#bookmarks_folderId:first').val());
- $('#deleteBlogrollName').html('<s:property value="%{folder.name}"/>');
+ $('#deleteBlogrollName').text('<s:property value="%{folder.name}"/>');
Review Comment:
`<s:property>` HTML-escapes with `escapeHtml4`, which doesn't touch `'`, so
a folder named `Matt's Links` renders as `.text('Matt's Links')` and the
`SyntaxError` takes out every function in this `<script>` block (delete/rename
buttons stop working). And now that it's `.text()`, `Tom & Jerry` displays as
`Tom & Jerry`. Use `<s:property value="%{folder.name}"
escapeJavaScript="true" escapeHtml="false"/>` here, or read the name from a
`data-` attribute on the trigger element instead of inlining it in JS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
