mraible commented on code in PR #175:
URL: https://github.com/apache/roller/pull/175#discussion_r3891448743
##########
app/src/main/webapp/WEB-INF/jsps/editor/MediaFileAddSuccess.jsp:
##########
@@ -96,7 +98,9 @@
<div class="col-md-1">
<input type="radio" name="enclosure"
- onchange="setEnclosure('<s:property
value="%{#newFile.permalink}"/>')"/>
+ onchange="setEnclosure('<s:property
value="%{#newFile.permalink}"/>',
+ '<s:property
value="%{#newFile.contentType}"/>',
Review Comment:
Use `escapeJavaScript="true" escapeHtml="false"`, or better, put the three
values in `data-` attributes and read them in the handler. (#174 changes how
`contentType` is derived, which narrows this, but the JSP should still not
inline it unescaped.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
