snoopdave opened a new pull request, #178:
URL: https://github.com/apache/roller/pull/178
Retires incoming Trackback and tidies how comment links are rendered.
Trackback is long obsolete: the ping endpoint attracts essentially nothing
but spam, and the code behind it is some of the least exercised in the tree.
Removing it deletes a public unauthenticated endpoint and the request plumbing
that fed it, rather than continuing to carry code nobody uses.
## Changes
- Remove `TrackbackServlet` and `WeblogTrackbackRequest`, and unmap the
servlet from `web.xml`.
- Keep `TrackbackLinkbackCommentValidator` as an inert validator so existing
configurations that name it keep starting, with test coverage pinning that
behaviour.
- Render the comment URL in the editor from a normalized, escaped value
rather than the raw stored one.
- Drop the trackback entries from the theme templates, the user guide and
the template guide.
## Note on provenance
This is the same work as #176, which was opened against the stacked
`entry-trackback-cleanup` branch and merged there rather than into `master`, so
it never reached the default branch. Rather than reopen that PR against a base
that is now behind, this branches from current `master`.
## Conflicts and how they were resolved
The original branch predates several changes that have since landed, so
seven files conflicted. Resolved to `master` wherever `master` is newer:
- `EntryEdit.java` — the Mediacast imports stay removed (they went with the
enclosure change).
- `ApplicationResources_{fr,ja,ko,zh_CN}.properties` — trailing blank lines
only; kept master's.
Resolved the other way where this branch is the newer intent:
- `Comments.jsp` — uses the escaped safe URL this branch introduces.
- `base.css` — takes this branch's line ending, which restores the file-wide
CRLF that one line on master had lost.
## Verification
Full suite on JDK 11: **297 tests, 0 failures, 0 errors, 1 skipped**,
including `IncomingTrackbackRemovalTest` (3).
Confirmed after the merge that the newer work already on master is intact —
the enclosure change's import removal, the entry authorization guard, and the
delegated enclosure listener — and that `TrackbackServlet` and
`WeblogTrackbackRequest` are gone with no remaining `web.xml` references.
https://claude.ai/code/session_019R1jdtwkaYEeA6L9DXEtEi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
