snoopdave commented on code in PR #182:
URL: https://github.com/apache/roller/pull/182#discussion_r3957682900
##########
app/src/main/java/org/apache/roller/weblogger/business/startup/DatabaseInstaller.java:
##########
@@ -254,6 +256,10 @@ public void upgradeDatabase(boolean runScripts) throws
StartupException {
// make sure the database version is the exact version
// we are upgrading too.
updateDatabaseVersion(con, myVersion);
+ if (!schemaChangesRequired) {
+ successMessage("No table changes were required.");
+ }
+ successMessage("Database version updated to " + myVersion + ".");
Review Comment:
Thanks — adopted your flag pattern in #184: a `schemaUpgraded` flag set
inside each upgrade block, so the "no table changes" message no longer depends
on the hardcoded 610. It's behavior-preserving (at that point `dbversion < 610`
is true exactly when a block runs), and I added a test for the schema-change
path. Folding it into 6.1.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
