snoopdave commented on code in PR #191:
URL: https://github.com/apache/roller/pull/191#discussion_r4040816584
##########
app/src/main/java/org/apache/roller/weblogger/ui/rendering/plugins/comments/LdapCommentAuthenticator.java:
##########
@@ -84,14 +85,14 @@ public String getHtml(HttpServletRequest request) {
sb.append("</p>");
sb.append("<p>");
sb.append("<input name=\"ldapUser\" value=\"");
- sb.append(ldapUser + "\">");
+
sb.append(StringEscapeUtils.escapeHtml4(ldapUser)).append("\">");
sb.append("</p>");
sb.append("<p>");
sb.append(messages.getString("comments.ldapAuthenticatorPassword"));
sb.append("</p>");
sb.append("<p>");
sb.append("<input type=\"password\" name=\"ldapPass\"
value=\"");
- sb.append(ldapPass + "\">");
+
sb.append(StringEscapeUtils.escapeHtml4(ldapPass)).append("\">");
Review Comment:
🐞Claude Issue: **Blocking:** This repopulates the password field's `value`
attribute with the submitted password, so the plaintext credential is written
into the rendered page source. From there it is reachable through view-source,
the browser's cache and back/forward history, and anything upstream that
captures response HTML.
Password inputs should not be repopulated. Drop the `value` attribute for
this field entirely:
```java
sb.append("<input type=\"password\" name=\"ldapPass\">");
```
Note that `preservesOrdinaryFormValues` in the new test asserts this
round-trip (`sample-pass` appearing in the markup), so that assertion needs
updating alongside the fix.
##########
app/src/test/java/org/apache/roller/weblogger/ui/rendering/plugins/comments/LdapCommentAuthenticatorTest.java:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.roller.weblogger.ui.rendering.plugins.comments;
+
+import java.util.Locale;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
+import org.junit.jupiter.api.Test;
+import org.mockito.MockedStatic;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+class LdapCommentAuthenticatorTest {
+
+ @Test
+ void rendersEmptyFieldsOnFirstVisit() {
+ HttpServletRequest request = mock(HttpServletRequest.class);
+ HttpSession session = mock(HttpSession.class);
+ when(request.getSession(true)).thenReturn(session);
+ String html = render(request);
+ assertFields(html, "", "");
+ verify(session).setAttribute("ldapUser", "");
+ verify(session).setAttribute("ldapPass", "");
+ }
+
+ @Test
+ void rendersMissingValuesAsEmpty() {
+ assertFields(renderReturningVisit(null, null), "", "");
+ }
+
+ @Test
+ void preservesOrdinaryFormValues() {
+ assertFields(renderReturningVisit("reader", "sample-pass"), "reader",
"sample-pass");
+ }
+
+ @Test
+ void formatsPunctuationInFormValues() {
+ String value = "A&B \"quoted\" <label> 'name'";
+ String formatted = "A&B "quoted" <label> 'name'";
+ assertFields(renderReturningVisit(value, value), formatted, formatted);
+ }
+
+ @Test
+ void preservesLiteralEntityText() {
+ assertFields(renderReturningVisit(""", """), "&quot;",
"&#34;");
+ }
+
+ private String renderReturningVisit(String user, String password) {
+ HttpServletRequest request = mock(HttpServletRequest.class);
+ HttpSession session = mock(HttpSession.class);
+ when(request.getSession(true)).thenReturn(session);
+ when(session.getAttribute("ldapUser")).thenReturn("");
+ when(request.getParameter("ldapUser")).thenReturn(user);
+ when(request.getParameter("ldapPass")).thenReturn(password);
+ return render(request);
+ }
+
+ private String render(HttpServletRequest request) {
+ try (MockedStatic<CommentAuthenticatorUtils> locales =
mockStatic(CommentAuthenticatorUtils.class)) {
+ locales.when(() ->
CommentAuthenticatorUtils.getLocale(request)).thenReturn(Locale.ENGLISH);
+ return new LdapCommentAuthenticator().getHtml(request);
+ }
+ }
+
+ private void assertFields(String html, String user, String password) {
+ assertTrue(html.contains("<input name=\"ldapUser\" value=\"" + user +
"\">"));
Review Comment:
🐞Claude Issue: **Important:** `assertTrue(html.contains(...))` reports only
`expected: <true> but was: <false>` when it fails — no expected value, no
actual HTML, and no indication which of the two fields broke. I confirmed this
by running the suite against the pre-change behaviour; the failure output gives
a maintainer nothing to work with.
Use the message overload, or compare extracted values directly:
```java
assertTrue(html.contains(expected), () -> "expected " + expected + " in " +
html);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
