mraible opened a new pull request, #194: URL: https://github.com/apache/roller/pull/194
88 Roller-owned files were missing the ASF license header: Java sources and tests (mostly package-info.java files), JSPs, Velocity templates, Struts validation and menu XML, planet ORM mappings, properties files, deployment descriptors, `sign-release.sh`, the CodeQL configs, `db-utils/pom.xml`, `version-rules.xml`, and the NetBeans `nbactions.xml` files. Each gets the header in the comment style its neighbors already use. Velocity templates need care because comments sit in rendered output: - Templates that emit markup or feeds (`rsd.vm`, `popupcomments.vm`, `noop_decorator.vm`, the menu and navbar templates) put the closing `*#` directly in front of their first output, the pattern the feed templates already use, so nothing they render changes. - Templates that begin with a directive or comment get a line break after the header, since `*##` would turn the next line into a line comment. For the SQL templates this adds one blank line to each generated script, which `SQLScriptRunner` skips. I compared the generated database scripts before and after: they differ only by that blank line. All unit tests pass. Left alone on purpose: - `docker/wait-for-it.sh` and the jQuery Mobile theme CSS are third-party code with their own licenses. - The bundled blog themes have never carried headers because their templates are copied into users' editable weblog templates. - `it-selenium` is removed by the Playwright PR (#157). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
