snoopdave commented on PR #203: URL: https://github.com/apache/roller/pull/203#issuecomment-5973417694
🐞Claude Issue: **PR-Review: General Issues** The following issues were found but cannot be attached to a specific line in the diff: - **Blocking:** There are no tests. `InlineImageData` (parsing, signature checks, size limits, `findSources` offsets), the `HTMLSanitizer` change that accepts data URLs, and the `EntryEdit` paths (keep inline, upload, too large, and cleanup after a failed save) all need coverage. `app/src/test/java/.../util/` and `.../ui/struts2/editor/EntryEdit*Test.java` already follow this pattern. Also add a test that `data:image/svg+xml` and `data:text/html` are still stripped by the sanitizer. - **Blocking:** `CHANGES.md` is not updated. Add a short entry for ROL-2184 that links the JIRA issue and mentions `weblog.inlineImages.preferInline` and the theme CSP change (`img-src * data:`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
