snoopdave commented on PR #200: URL: https://github.com/apache/roller/pull/200#issuecomment-5973457396
🐞Claude Issue: **PR-Review: General Issues** The following issues were found but cannot be attached to a specific line in the diff: - **Blocking:** `CHANGES.md` on `roller-6.1.x` is not updated. This is a default change that breaks existing sites: Planet admin pages and `/planetrss` go dark on upgrade unless `planet.aggregator.enabled=true` is set. The upgrade note in the PR description belongs in `CHANGES.md` (and the 6.1.7 release notes), not only here. - **Important:** `RefreshRollerPlanetTask` and `SyncWebsitesTask` do not check `planet.aggregator.enabled`. They are not in the default `tasks.enabled`. But a site that has added them and then upgrades will keep fetching subscribed feeds with Planet "off". If off is meant to mean off, have both tasks return early when the flag is false. - **Important:** No CI runs on this PR, because the `roller-6.1.x` workflows trigger only for `master`. I ran `PlanetAvailabilityTest` (6) and `RequiresPostInterceptorTest` (5) locally on JDK 11: all pass. I also confirmed that every state-changing Planet action method (`save`, `saveGroup`, `saveSubscription`, `deleteSubscription`, `delete`) is annotated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
