snoopdave commented on code in PR #161:
URL: https://github.com/apache/roller/pull/161#discussion_r4238477643
##########
app/pom.xml:
##########
@@ -529,11 +529,12 @@ limitations under the License.
</exclusions>
</dependency>
- <!-- todo: remove/replace propono -->
+ <!-- Used by Trackback; previously reached the classpath transitively
Review Comment:
🤖Claude: fixed by removing the commons-httpclient 3.1 dependency block (and
its stale Trackback comment) from app/pom.xml. Nothing in app/src uses it; the
full app test suite passes without it.
##########
app/src/main/java/org/apache/roller/weblogger/webservices/atomprotocol/MediaCollection.java:
##########
@@ -195,16 +180,16 @@ public Entry postMedia(AtomRequest areq, Entry entry)
throws AtomException {
}
}
throw new AtomException("Error saving media entry");
-
+
} catch (WebloggerException re) {
throw new AtomException("Posting media", re);
} catch (IOException ioe) {
throw new AtomException("Posting media", ioe);
}
}
-
-
- public Entry getEntry(AtomRequest areq) throws AtomException {
+
+
+ public AtomEntry getEntry(AtomRequest areq) throws AtomException {
Review Comment:
🤖Claude: fixed by making MediaCollection.getEntry() return
AtomNotFoundException for an unknown weblog and AtomNotAuthorizedException when
!canView(user, website), matching getCollection(). Tests:
mediaLinkEntryOfAnUnknownWeblogIsNotFound,
mediaLinkEntryNeedsPermissionOnTheWeblog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
