snoopdave commented on PR #233:
URL: https://github.com/apache/roller/pull/233#issuecomment-6566521199

   **PR-Review: General Issues**
   
   The following issues were found but cannot be attached to a specific line in 
the diff:
   
   - 🐞Claude Issue: **Important:** `CHANGES.md` is not updated. It has a 7.0.0 
section, and this PR changes the media library in ways users will see. 
Suggested entry: one sentence, then bullets for search, sort and paging; 
multi-file upload with per-file results; and the media file details page.
   - 🐞Claude Issue: **Important:** `MediaFileFilter.java`, `MediaFileBase.java` 
and `EntryAddWithMediaFile.java` change from CRLF to LF line endings. Their 
diffs show 286, 485 and 328 changed lines, but only about 15, 15 and 30 lines 
really change, and `git blame` for those files now points at this PR. The 
repository has no `.gitattributes`, and 7 other Java files are still CRLF. 
Restore CRLF in these three files, or move the line-ending change into its own 
commit.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to