mraible opened a new pull request, #260: URL: https://github.com/apache/roller/pull/260
Upgrades ROME, the feed library Planet uses, from 1.19.0 to 2.1.0. ROME 2.1.0 targets Java 8 (class file version 52), keeps `java.util.Date` in its feed model, and renames no packages. The modules it dropped (fetcher, Propono, certiorem) aren't used by Roller. One behaviour change mattered. For Atom 1.0 feeds, `SyndFeed.getLink()` now returns the `rel="self"` link (the feed's own URL) instead of the first alternate link (rometools/rome#538). Planet stores that value as the subscription's site URL, so Atom subscriptions would have linked to the feed instead of the blog. `RomeFeedFetcher.siteURL()` now takes the first link whose `rel` is blank or `alternate`, and falls back to `getLink()`, which is still the channel link for RSS. `RomeFeedFetcherLocalTest` serves feeds from a JDK `HttpServer` on a random loopback port, so it doesn't need the network. It covers: - the Atom site URL, dates with offsets, author, content, categories and the conditional fetch - RSS 2.0 `pubDate`, the `dc:date` fallback, `dc:creator` and `content:encoded` - RSS 0.91 item dates - that Planet's converters, parser and content module load from `rome.properties` - that a feed with a DOCTYPE is refused All of it also passes on ROME 1.19.0 with the old code. On 2.1.0 without the fix, the site URL test fails. `mvn test` passes (665 tests). Planet's feed parsing keeps ROME's own hardened parser setup, which is unchanged in 2.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
