mraible commented on PR #264:
URL: https://github.com/apache/roller/pull/264#issuecomment-6886561287

   I've now run this branch against the same data, with plain master as a 
control. Each build went through the same sequence, and I looked in the index 
directory after each step.
   
   | Step | master (f3d120760) | master + this branch |
   | --- | --- | --- |
   | Normal start | marker present | marker present |
   | Container killed, restarted: index rebuilt | marker gone while running | 
marker present |
   | Killed again after that rebuild | no rebuild, index file untouched | 
rebuilt again |
   | Clean stop | not checked | marker removed |
   | Start after a clean stop | no rebuild | no rebuild |
   
   So master reproduces the bug: after one rebuild, a second crash goes 
unnoticed. With this branch the marker survives the rebuild, the second crash 
is caught, and a clean shutdown still removes the marker so the next start 
doesn't rebuild.
   
   Search returned the same counts throughout on both builds, and neither 
logged an error.
   
   One limit: this index is small (3,553 entries, under 5 MB) and rebuilds in a 
few seconds, so my kills landed after the rebuild had finished, not during it. 
I didn't exercise a crash in the middle of a rebuild.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to