mraible commented on PR #266:
URL: https://github.com/apache/roller/pull/266#issuecomment-6886897527

   aef6e4a3c goes through the 12 files left in `images/` and the 26 in 
`roller-ui/images/` and `roller-ui/theme/`.
   
   Replaced with Bootstrap Icons, the same way as the theme icons:
   - `feed-icon-12x12.gif`, added in 2006 as "the industry standard feed icon": 
now an inline `rss-fill` in the basic and basicmobile themes' feed list.
   - `smrssbadge.gif` and `rssbadge.gif`, from the 2005 import: now an inline 
`rss-fill` in the blogroll macro and the front page theme.
   - `launch-link.png`, added in 2007 with no source recorded: now 
`bi-box-arrow-up-right` beside the permalink in the entry editor.
   
   Removed because nothing references them:
   - `openid-logo-small.gif`, `atombadge.jpeg`, `opml.png` and `permalink.gif`.
   - `roller-ui/images/layout.png` (it looks like a Silk icon), 
`logo-shadow.png` and `transparent-logo.png`.
   - `roller-ui/theme/blue/` and `sun/` entirely, and `tan/` apart from 
`menutab-sel.gif` and `menutab-unsel.gif`, which the front page theme uses. The 
three `colors.css` files weren't loaded by anything.
   
   Left in place, and I can't confirm these from the repository alone:
   - `roller-logo.png`, `rollerbadge.jpg` and `rollerbadge.png`: Roller's own 
logo and "Powered by" badge. Nothing references them, but sites link to the 
badge. Git shows them arriving in the June 2005 import.
   - `tinyfeather.png` and `roller-ui/images/feather.svg`: the Apache feather.
   - `roller-ui/images/menutab-tl.gif`, `menutab-tr.gif`, `dash.gif`, 
`spacer.png` and the two `tan/menutab-*.gif`: tab corners, a dash, a 1x1 spacer 
and gradients, all from 2005.
   - `roller-ui/images/clippy.svg` isn't referenced either. I left it because 
#265 already credits it to Octicons.
   
   Dave, you committed all of the 2005 files, so could you confirm the Roller 
logo, the badges and the tab images were made for the project? If any weren't, 
I'll replace those too.
   
   `atom.xsl` and `rss.xsl` both point at a `two-banner.gif` beside them that 
has never existed there. I left that alone.
   
   `mvn test` passes (669). CHANGES lists the extra removals. #265 doesn't need 
new credits for this, since the additions are Bootstrap Icons it already covers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to