mraible commented on PR #271:
URL: https://github.com/apache/roller/pull/271#issuecomment-6896514596

   One gap, and one optional hardening:
   
   - **The cache key fix only covers regular weblogs.** `PageServlet` uses 
`SiteWideCache.generateKey` for the site-wide weblog (`PageServlet.java:205`), 
and that method still has the old logic. A custom page that names an entry 
still shares the entry's key there, and tags are only keyed in the `tags` 
context. The same change in `SiteWideCache`, or a helper both caches call, plus 
a case in `WeblogPageCacheKeyTest`, would cover the front page weblog too.
   - **Optional:** tags from a custom page's `?tags=` aren't capped by 
`tags.queries.maxIntersectionSize` the way the `/tags/` path is 
(`WeblogPageRequest.java:150`). That existed before this PR, since custom pages 
without an entry already ran the same lookup. Applying the same cap in the 
`page` context would close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to