mraible opened a new pull request, #274:
URL: https://github.com/apache/roller/pull/274

   A follow-up to #271. It fixed the cache key in `WeblogPageCache`, but 
`PageServlet` uses `SiteWideCache.generateKey` for the site-wide weblog 
(`PageServlet.java:205`), and that method still had the old logic. On the front 
page weblog:
   
   - a custom page that names an entry shared the entry's own key;
   - tags given to a custom page weren't part of the key.
   
   So one of those pages could still be served in place of another, which is 
what #271's CHANGES entry says no longer happens. `SiteWideCache` now builds 
those parts of the key the same way `WeblogPageCache` does.
   
   `WeblogPageCacheKeyTest` now runs each of its cases against both caches. 
Three of the four fail on `roller-6.1.x` for the site-wide cache and pass here.
   
   Not included, in case you want it separately: tags from a custom page's 
`?tags=` still aren't capped by `tags.queries.maxIntersectionSize` the way the 
`/tags/` path is. That was already the case before #271.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to