mraible opened a new pull request, #292:
URL: https://github.com/apache/roller/pull/292

   \`IPBanListTest.isBanned4\` has been \`@Disabled\` since 2021 because it 
failed intermittently. It's the only skipped test in the build.
   
   \`IPBanList\` reloads its file when the file's modification time changes. 
The test rewrote the file right after creating it, and on filesystems with 
coarse timestamps the time could stay the same, so the reload was skipped. The 
500 ms sleep came after the write, so it couldn't help.
   
   - The test now moves the file's modification time forward explicitly instead 
of sleeping, so it no longer depends on timestamp resolution.
   - Putting the original time back after the write makes the test fail, which 
shows it exercises the reload check.
   - \`IPBanListTest\` passed 5 runs in a row locally (JDK 21).
   
   Test-only change, so there's no CHANGES entry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to