mraible opened a new pull request, #295:
URL: https://github.com/apache/roller/pull/295

   The OpenID login filter at `/roller_j_openid_security_check` is part of the 
Spring Security filter chain whatever `authentication.method` is set to. This 
makes it do nothing unless the method is `openid` or `db-openid`, so sites 
using database, LDAP or container authentication don't run OpenID discovery at 
all.
   
   When OpenID is enabled, XRDS documents found during discovery are now read 
with `SecureXmlParsers`, the XML parser settings Roller already uses for the 
XML it reads itself, before openid4java parses them. openid4java loads 
`openid4java.properties` from the classpath root on top of its defaults, so the 
new file there points `discovery.xrds.parser` at `RollerXrdsParser`.
   
   - `CustomOpenIDAuthenticationProcessingFilterTest` checks the login URL is 
handled for `openid` and `db-openid` and ignored for every other method.
   - `RollerXrdsParserTest` checks that openid4java loads the new parser, that 
a normal XRDS document still parses, and that documents with a document type 
declaration or malformed XML are refused.
   - `mvn install` passes on JDK 11 (520 tests, 1 skipped), and the it-selenium 
tests pass.
   
   This is for 6.1.x only. Roller 7 no longer includes OpenID 2.0 login.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to