mraible opened a new pull request, #302:
URL: https://github.com/apache/roller/pull/302

   A follow-up to #301, from a review of #300.
   
   When a login re-encodes a password stored with an older encoding, 
`RollerUserDetailsService.updatePassword` now releases the persistence session, 
reads the user again and stores the re-encoded password only if the stored 
password is still the one the login checked. If an administrator changed it in 
the meantime, that change is kept.
   
   `PersistenceSessionFilter` now comes first in `web.xml`. It releases the 
thread's persistence session when a request is done, but it came after Spring 
Security, so requests Spring Security answers itself (login posts, failed 
logins, the OAuth2 callback) never reached it, and the session they used to 
read users stayed open for the next request on that thread. The filter doesn't 
read the request, so it can come ahead of `CharEncodingFilter`.
   
   - `PasswordUpgradeTest` has a case where the password is reset after the 
login read the user; it fails without the change (the reset is overwritten by 
the re-encoded old password).
   - `FilterOrderTest` checks that `PersistenceSessionFilter` is the first 
filter mapping.
   - `mvn test` passes (749 tests), and the Playwright database-login suite 
passes against `jetty:run` (20 run, 3 OIDC tests skipped).
   
   No CHANGES entry: the password upgrade from #301 hasn't been released yet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to