mraible opened a new pull request, #304: URL: https://github.com/apache/roller/pull/304
Users who log in through LDAP or the servlet container have `users.passwords.externalAuthValue` (by default `<externalAuth>`) stored in place of a Roller password. `RollerPasswordEncoders` now wraps the encoder so that `matches()` never accepts that placeholder, wherever Roller checks a password with it. Encoding and `upgradeEncoding` are unchanged, and stored passwords aren't touched. `create()` now returns `PasswordEncoder` instead of `DelegatingPasswordEncoder`; its callers already use it as a `PasswordEncoder`, including #300's `SecurityConfig`. - `ExternalLoginPlaceholderTest` checks a login through `DaoAuthenticationProvider` and `RollerUserDetailsService` for a user whose stored password is the placeholder, encoded and unencoded, and the encoder directly. The login cases fail without the change. - A test merge with #300 is clean, and their tests pass together. - `mvn test` passes (752 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
