mraible opened a new pull request, #314:
URL: https://github.com/apache/roller/pull/314

   The planet feed fetcher now has one deadline for the whole fetch and a size 
limit for the body. Before, only the connection and response headers had 
timeouts.
   
   - `planet.aggregator.fetch.maxBytes` (default 5 MB) caps the body; a 
`Content-Length` over it is rejected before reading.
   - `planet.aggregator.fetch.maxSeconds` (default 30) covers connecting, the 
headers and the body, so a feed that stalls or arrives slowly is cancelled.
   - Feed URLs other than http and https fail with a `FetcherException` that 
says so. Local `weblogger:` feeds are handled before this, as before.
   
   The new properties are in `roller.properties`, next to the other 
`planet.aggregator.*` settings.
   
   Tests: `RomeFeedFetcherLimitsTest` runs an in-JVM HTTP server and covers a 
normal feed, oversized feeds (with and without `Content-Length`), a slow and a 
stalled feed, and a non-HTTP URL. `RomeFeedFetcherLocalTest` and 
`WebloggerRomeFeedFetcherTest` still pass, and `mvn test` passes (755 tests).
   
   CHANGES entries for this and the related fixes will come in one PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to