snoopdave commented on code in PR #321:
URL: https://github.com/apache/roller/pull/321#discussion_r4608384719
##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/core/Profile.java:
##########
@@ -124,6 +125,8 @@ public String save() {
UserManager mgr =
WebloggerFactory.getWeblogger().getUserManager();
mgr.saveUser(existingUser);
WebloggerFactory.getWeblogger().flush();
+ // a password change ends the user's other sessions, not this
one
+ RollerSession.refreshPassword(getServletRequest(),
existingUser);
Review Comment:
**Important:** For OIDC and DB_OIDC accounts with an OpenID URL,
`Profile.save()` generates a fresh random stored password on every save.
`UserEdit.save()` does the same. With the new digest check, changing only a
profile field ends the user's other sessions. Preserve the stored password when
no credential or sign-in method changes, and test a profile-only OIDC save with
two sessions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]