snoopdave commented on code in PR #318:
URL: https://github.com/apache/roller/pull/318#discussion_r4608482312


##########
app/src/main/webapp/WEB-INF/velocity/feeds.vm:
##########
@@ -32,7 +32,7 @@
     <entry>
         <id>$entry.permalink</id>
         <title type="html">$utils.escapeXML($entry.title)</title>
-        <author><name>$entry.creator.screenName</name></author>
+        
<author><name>$utils.escapeXML($utils.unescapeHTML($entry.creator.screenName))</name></author>

Review Comment:
   **Important:** The comment author branches in `showCommentsAtom10` and 
`showCommentsRSS20` still use `escapeXML(removeHTML($comment.name))`. 
`WeblogEntryCommentWrapper.getName()` already HTML-escapes the name, so a name 
such as `A & B` appears as `A &amp; B` to feed readers. Use the same 
`unescapeHTML()` then `escapeXML()` sequence here, and cover both comment feeds 
in the feed test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to