snoopdave commented on code in PR #324:
URL: https://github.com/apache/roller/pull/324#discussion_r4608619664


##########
CHANGES.md:
##########
@@ -54,6 +54,22 @@
 
 ### Bug fixes
 
+- **Changing a password ends the account's other sessions.** Saving a new

Review Comment:
   **Important:** Add 7.0.0 entries for the master counterparts of four fixes 
listed in #336: external-login password handling (#304), login request 
persistence-session cleanup (merged in #302), media URLs serving files only 
from their own weblog (#308), and Roller UI static files no longer starting 
sessions (#310). Coordinate the entries with those PRs before merging this 
changelog.



##########
CHANGES.md:
##########
@@ -146,6 +162,43 @@
 
 ### Behaviour changes worth reading before upgrading
 
+- **Weblog templates have render limits.** A page stops rendering, with a
+  logged error, once it writes more than `rendering.maxOutputChars` (10 MB)
+  or runs longer than `rendering.maxRenderSeconds` (30 seconds); `#foreach`
+  stops at 100,000 passes, and `String.repeat` isn't available. `#parse` and
+  `#include` load only the weblog's own templates, and macros defined inline
+  in a template are local to it, so weblogs can't affect each other's macros.
+  Library macros such as `roller.vm` and a site's own `roller-custom.vm` stay
+  global. Error pages no longer show template ids (#317).
+- **Entries with scripts or embeds open as HTML.** If an entry contains
+  scripts, frames, embedded objects, event-handler attributes or
+  `javascript:` links, the rich-text editor opens it in the HTML textarea
+  with a notice, and the stored HTML is kept as is (#319).
+- **Names are shown as text.** Screen and full names are HTML-escaped where
+  templates print them and written as plain text in feeds; commenter names
+  and addresses are escaped in HTML notification emails; HTML comments are
+  escaped unless the HTMLSubset plugin applies to them (#318).
+- **Limits on uploads and fetched feeds.** Images with more pixels than
+  `uploads.thumbnail.maxPixels` (50 million) are stored without a thumbnail
+  (#315). Planet stops reading a feed past `planet.aggregator.fetch.maxBytes`
+  (5 MB) or `planet.aggregator.fetch.maxSeconds` (30 seconds), and fetches
+  only http and https URLs (#314).
+- **AtomPub checks.** Publishing an entry through an AtomPub update needs the
+  permission to publish, media uploads over `uploads.file.maxsize` are
+  refused with 413 before they're stored, and entries show the creator's
+  email address only to the creator (also in MetaWeblog responses) (#316).
+- **Search queries are limited to 256 characters**, and a query the search
+  engine can't run finds nothing (#322).
+- **The OpenID Connect identity can't be changed from the profile or
+  registration forms**; only Roller's OpenID Connect login sets it (#322).
+- **Weblog pages ignore a `skipCache` query parameter** (#313).
+- **Set `site.absoluteurl`.** Roller no longer takes the site's URL from the

Review Comment:
   **Important:** The first administrator's request saves `site.absoluteurl`, 
which may need correction when the site is reached through a proxy or multiple 
host names. As #336 does, tell administrators to check “Absolute URL to site” 
under Server Administration > Configuration after upgrading. Also mention the 
removal of `WebloggerRuntimeConfig.setAbsoluteContextURL` and 
`InitFilter.getAbsoluteUrl`, which #320 removes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to