mraible commented on code in PR #333:
URL: https://github.com/apache/roller/pull/333#discussion_r4609096240


##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/core/Profile.java:
##########
@@ -122,6 +128,8 @@ public String save() {
                 UserManager mgr = 
WebloggerFactory.getWeblogger().getUserManager();
                 mgr.saveUser(existingUser);
                 WebloggerFactory.getWeblogger().flush();
+                // a password change ends the user's other sessions, not this 
one
+                RollerSession.refreshPassword(getServletRequest(), 
existingUser);

Review Comment:
   Profile.save and UserEdit.save now generate a stored password for OPENID and 
DB_OPENID accounts only when the account has none or its OpenID URL changes, so 
editing a name or locale keeps the user's other sessions. 
PasswordChangeSessionTest covers an OpenID profile edit and an administrator 
edit with a second session open (both failed before the change), plus switching 
an account to OpenID, which still replaces the stored password.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to