mraible commented on PR #319: URL: https://github.com/apache/roller/pull/319#issuecomment-6968820191
A second review raised a few more points, now addressed in the latest commits: - Also from review: entries with textarea, title, xmp, noembed, noframes or plaintext elements now open in the textarea, and so do entries whose element tree changes when it is serialized and parsed again, as the rich editor does for undo and code view (nested forms and the math/mglyph cases). The comparison covers elements, namespaces and attributes but not text, so a pre starting with a blank line stays in the rich editor; RichEditorContentIT covers these cases. - On the editor setting: Summernote's editor id is editor-xinha.jsp, so weblogs with the old xinha value get Summernote directly, but plugins.defaultEditor=editor-summernote.jsp matches no configured editor, so weblogs with other unknown values (such as ekit) fall back to the first configured editor, the plain text one. This PR doesn't change that lookup; the description will be corrected to say so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
