mraible opened a new pull request, #342: URL: https://github.com/apache/roller/pull/342
Follows up #309 from review. With the overlay `mediaFileAdd` action gone, nothing reads `overlayMode`: `MediaFileImageChooser` was given it but never used it, and `MediaFileAdd` only runs outside the overlay. The flag is removed from `MediaFileBase` and `MediaFileAdd`. The `mediaFileAddExternalInclude` action, its tile and `MediaFileAddExternalInclude.jsp` aren't linked from any page either, so they're removed too. `MediaFileBase.java` had mixed CRLF and LF line endings and now has LF only, so its diff is larger than the change; with whitespace ignored, it's ten removed lines. Tests: `StrutsParameterAnnotationTest` no longer lists the removed JSP as an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
