mraible opened a new pull request, #343: URL: https://github.com/apache/roller/pull/343
Stacked on #304, so merge #304 first; until then this PR's diff includes its commits. Follows up #323 from review. - A password over 72 bytes in UTF-8 (for example 20 emoji) made BCrypt throw when registration, the profile page or the admin user editor saved it, so the user got an error page. The forms now check the length first, with the new `RollerPasswordEncoders.isTooLong`, and say the password is too long (`userRegister.error.passwordTooLong`). The profile page checks it whether or not an OpenID URL is given, since it saves a typed password either way. - Registration put the random password it generates for OIDC users in the form's hidden password fields, so a registration that failed validation, for example on a taken user name, sent it back to the browser. It now keeps that password in the action and uses it only when saving the user. Tests: `PasswordFormValidationTest` covers registration and the profile page (with and without an OpenID URL), a password at the limit, and the generated password staying out of the form; `UserEditPasswordLengthTest` covers the admin user editor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
