mraible commented on PR #317: URL: https://github.com/apache/roller/pull/317#issuecomment-6968819219
A second review raised a few more points, now addressed in the latest commits: - Also from review: string literals with many references, + concatenation, and #define blocks or macro bodies used as strings now stop at the output limit while the string is built (RenderLimitParser, set as parser.class), and regular expressions passed to matches, replaceAll, replaceFirst and split check the render deadline as they run; RenderLimitsTest has a case for each that fails without the change. A recursive macro that writes nothing already stopped at the deadline, because every block render writes to the counted output, so that case only gained a test. The decorator path wasn't changed: velocityDecorator is never assigned, so it never runs. RollerResourceLoader now refuses to start with resource.loader.roller.cache=true, with a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
